Skip to content

Add search this user/agent to ProfilePage - #99295

Merged
Julesssss merged 14 commits into
Expensify:mainfrom
hungvu193:revert-99104-revert-98091-feat-98076-add-search-user
Sep 21, 2026
Merged

Julesssss merged 14 commits into
Expensify:mainfrom
hungvu193:revert-99104-revert-98091-feat-98076-add-search-user

Conversation

@hungvu193

@hungvu193 hungvu193 commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Add "🔍 Search this user" (or "Search this agent") to all profiles to view all report actions of that user/agent.

Fixed Issues

$ #98076
$ #99073
PROPOSAL: N/A

Tests

Same as QA steps.

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Test 1:

  1. Go to a room or a chat.
  2. Click on an agent profile > Verify there's View agent history button > Click on it
  3. Verify it navigates to Search and filters that agent's messages.
  4. Go back to any other chat and click on a user profile > View user history
  5. Verify it navigates to Search and filter that user's messages.

Test 2:
Precondition:

  • Create a new Gmail account. Do not verify the account.
  • Create an agent on Account > Agents.
  1. Launch Expensify app.
  2. Go to Account > Agents.
  3. Tap on the agent.
  4. Tap Chat with agent.
  5. Tap on the chat header.
  6. Tap View agent history.
  7. Swipe back three times.
  8. Verify there is validate code page appears.

Test 3:

  1. Go to Agents
  2. click on a Agent.
  3. Click View agent history
  4. Verify you're navigated to Search and see agent messages history.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-08-09.at.14.37.48.mov
Android: mWeb Chrome
Screen.Recording.2026-08-09.at.14.37.48.mov
iOS: Native
Screen.Recording.2026-08-09.at.14.33.53.mov
iOS: mWeb Safari
Screen.Recording.2026-08-09.at.13.33.44.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-10.at.10.06.23.mov

@melvin-bot

melvin-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@hungvu193 hungvu193 changed the title "Add search this user/agent to ProfilePage"" Add search this user/agent to ProfilePage Aug 24, 2026
@hungvu193

Copy link
Copy Markdown
Contributor Author

@MelvinBot We have this regression:
#99073 (comment)

Can you propose the solution?

@MelvinBot

Copy link
Copy Markdown
Contributor

Proposed fix

Swap the direct Navigation.navigate for Navigation.revealRouteBeforeDismissingModal in the button's onPress — ProfilePage.tsx:349:

- Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query, rawQuery: query}));
+ Navigation.revealRouteBeforeDismissingModal(ROUTES.SEARCH_ROOT.getRoute({query, rawQuery: query}));

Why: ProfilePage is rendered inside the RHP. SEARCH_ROOT is a tab-root path, so calling Navigation.navigate on it rebuilds a fresh tab navigator from the URL — dropping the RHP and the Agents back-history. Since the tab navigator uses backBehavior="fullHistory", swiping back then walks down to the first tab (Home, index 0), which for an unverified account renders the "Validate your account" widget instead of returning to Agents.

revealRouteBeforeDismissingModal inserts the Search route underneath the open RHP and then dismisses the modal, so the underlying fullscreen stack (the Agents flow) is preserved beneath Search rather than wiped. This is the established pattern for jumping to Search from within a modal — see navigateAfterExpenseCreate.ts:121 and submitDismissStrategies.ts:118, which both use it to reach SEARCH_ROOT from an RHP.

Evidence & mechanism
  • Trigger: ProfilePage.tsx:344-350 — the new "View user/agent history" MenuItem navigates directly to SEARCH_ROOT from inside the RHP.
  • URL → fresh tab strip: buildTabNavigatorNestedState.ts:17-35 builds a full tab strip with only the Search tab hydrated; other tabs default to their roots (Home at index 0). No RHP, no prior back-history.
  • Back walks to Home: TabNavigator.tsx:113 — backBehavior="fullHistory" unwinds to the first tab.
  • Helper behavior: revealRouteBeforeDismissingModal dispatches REPLACE_FULLSCREEN_UNDER_RHP to insert the route under the RHP, then dismissModal on the next frame (waitForTransition: getIsNarrowLayout() handles narrow layouts) — src/libs/Navigation/Navigation.ts.

Alternative (only if the above doesn't unwind cleanly enough back to Agents): dismiss first, navigate in the callback —

Navigation.dismissModal({
    afterTransition: () => Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query, rawQuery: query})),
});

but revealRouteBeforeDismissingModal is the more idiomatic, better-tested choice.

Worth verifying after the change: the exact Agents flow on a narrow/mobile layout — that pressing "View agent history" opens Search and swiping back returns to Agents, not the Home/validate screen — since navigateAfterExpenseCreate treats narrow vs wide differently. A quick manual repro of the reported flow should confirm it.


view run

@hungvu193

Copy link
Copy Markdown
Contributor Author

@MelvinBot We should use revealRouteBeforeDismissingModal it will introduce another bugs, check the comment below:

  1. Launch Expensify app.
  2. Go to Account > Agents.
  3. Tap on the agent.
  4. Tap Chat with agent.
  5. Tap on the chat header.
  6. Tap View agent history.
  7. Try to swipe back
  8. Unable to use swipe action to navigate

@MelvinBot

Copy link
Copy Markdown
Contributor

You're right — revealRouteBeforeDismissingModal won't restore the swipe. Here's the corrected picture.

Why swipe-back can't work when the destination is Search

Search isn't a card on a stack — it's a bottom-tab root inside the single shared TabNavigator (TAB_SCREENS.ts:9: Home, Reports, Search, Settings, Workspaces are all siblings). Any navigation whose destination is the Search tab ends with the root native stack holding one card ([TabNavigator(Search)]). Native edge-swipe pops the previous card — and there isn't one. So the missing swipe is inherent to landing on the Search tab, exactly like tapping "Search" in the bottom tab bar. revealRouteBeforeDismissingModal and the current navigate both end in that same single-card state, so neither can give you an edge-swipe.

So the real question is which "back" you want:

Option A — keep results on the Search tab, fix system/tab-bar back (small, recommended)

Dismiss the RHP first, then navigate. After the dismiss the top route is the TabNavigator, so navigate becomes a plain in-place tab switch that appends to the tab's fullHistory — so hardware/system back and the tab bar walk back Search → the report → Agents, instead of unwinding a freshly-rebuilt strip down to the Home/"Validate your account" tab. Replace ProfilePage.tsx:349:

Navigation.dismissModal();
setNavigationActionToMicrotaskQueue(() => {
    Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query, rawQuery: query}));
});

This mirrors the app's own "leave an RHP and land in a tab" convention in dismissModalAndOpenReportInInboxTab.ts:47-52. It fixes the original "swipe 3× → Validate your account" regression. It does not add an iOS edge-swipe — because a tab root can't have one.

Option B — you truly need edge-swipe back to the report

Then the results can't live on the Search tab at all; they'd have to render in a pushed, non-tab-root route (an RHP or a pushed search-results screen over the originating tab) so there's a real previous card to swipe back to. That's a larger routing change, beyond a hotfix.

Mechanism & evidence
  • Current navigate(SEARCH_ROOT) from the RHP: linkTo forces a PUSH of a brand-new full tab strip above the RHP; backBehavior="fullHistory" (TabNavigator.native.tsx) then unwinds that fresh strip to Home (index 0) → the Validate screen. This is the reported 3-swipe regression.
  • revealRouteBeforeDismissingModal(SEARCH_ROOT): dispatches REPLACE_FULLSCREEN_UNDER_RHP — for a tab target this switches the existing TabNavigator to Search in place, then dismisses the RHP → [TabNavigator(Search)], a single card → no edge-swipe target (what you observed). Tab history is preserved, so system/tab-bar back does still work.
  • Option A (dismiss → navigate): after dismissModal the top is the TabNavigator, so navigate is an in-place tab switch keeping fullHistory = Settings → Reports → Search → back returns to the report, then Agents. Same clean end state as reveal, but via the plain, well-tested dismissModal → navigate path rather than the REPLACE_FULLSCREEN_UNDER_RHP remount.
  • No earlier known-good variant exists: the original Add search this user/agent to ProfilePage #98091 used the identical navigate(SEARCH_ROOT) call.

setNavigationActionToMicrotaskQueue is imported from @libs/Navigation/helpers/setNavigationActionToMicrotaskQueue.

Which behavior are you after — Option A (back returns to Agents via system/tab-bar back, no edge-swipe) or Option B (literal edge-swipe, bigger change)? Worth confirming Option A on iOS/Android/web, since "swipe" means a different gesture on each.


view run

@hungvu193

Copy link
Copy Markdown
Contributor Author

@MelvinBot Let's go with A then

@MelvinBot

Copy link
Copy Markdown
Contributor

Done — implemented Option A and pushed to this branch (hungvu193).

Change: dismiss the RHP first, then navigate to Search on the microtask queue so it's an in-place tab switch that preserves tab history — ProfilePage.tsx:344-357:

Navigation.dismissModal();
setNavigationActionToMicrotaskQueue(() => {
    Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query, rawQuery: query}));
});

This mirrors the app's existing "leave an RHP and land in a tab" convention in dismissModalAndOpenReportInInboxTab.ts:47-52. It fixes the "swipe back 3× → Validate your account" regression by letting hardware/system back and the tab bar walk back Search → the report → Agents. (As discussed, it does not add an iOS edge-swipe on the Search tab — that's inherent to a tab root and would need the larger Option B.)

I also updated ProfilePageTest.tsx to assert the RHP is dismissed before navigating.

Checks run locally
  • ESLint (changed files) — pass (only a pre-existing seatbelt warning unrelated to this change)
  • typecheck-tsgo — pass
  • react-compiler-compliance-check (ProfilePage.tsx) — pass
  • Jest tests/ui/ProfilePageTest.tsx — 21/21 pass

I tried a web smoke test of the flow but the test session rendered a blank page (a CI session bring-up issue, unrelated to this change), so I couldn't exercise it in-browser.

Please verify the reported flow on iOS/Android — Account > Agents > agent > Chat with agent > chat header > View agent history, then back — returns to Agents rather than the Home/validate screen, since "swipe/back" behaves differently per platform.


view run

@hungvu193

Copy link
Copy Markdown
Contributor Author

I can verify it fixed our previous issue:

Screen.Recording.2026-08-24.at.18.32.55.mov

@hungvu193
hungvu193 marked this pull request as ready for review August 24, 2026 11:41
@hungvu193
hungvu193 requested review from a team as code owners August 24, 2026 11:41
@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and marufsharifi and removed request for a team August 24, 2026 11:41
@melvin-bot

melvin-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown

@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 24, 2026 11:41
@marufsharifi

marufsharifi commented Aug 24, 2026 •

Copy link
Copy Markdown

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-09-01.at.7.17.38.PM.mov
Screen.Recording.2026-09-01.at.7.18.39.PM.mov
Android: mWeb Chrome
Recording_20260901_192919.mp4
Recording_20260901_193045.mp4
iOS: HybridApp
Screen.Recording.2026-09-01.at.7.40.11.PM.mov
Screen.Recording.2026-09-01.at.7.41.04.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-09-01.at.7.45.20.PM.mov
Screen.Recording.2026-09-01.at.7.47.18.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-01.at.6.58.21.PM.mov
Screen.Recording.2026-09-01.at.7.01.01.PM.mov

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 89d8ec6e6c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/ProfilePage.tsx Resolved

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for product.

Comment thread tests/ui/ProfilePageTest.tsx Resolved
Comment thread tests/ui/ProfilePageTest.tsx Resolved
@marufsharifi

Copy link
Copy Markdown

@hungvu193, could you please update the QA steps based on latest updates. thanks.

@hungvu193

Copy link
Copy Markdown
Contributor Author

@hungvu193, could you please update the QA steps based on latest updates. thanks.

Cool. Updated

@hungvu193
hungvu193 requested a review from marufsharifi August 25, 2026 04:00
@marufsharifi

Copy link
Copy Markdown

@hungvu193, could you please merge the main. thanks.

@hungvu193

Copy link
Copy Markdown
Contributor Author

@hungvu193, could you please merge the main. thanks.

Sure.

@marufsharifi marufsharifi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot
melvin-bot Bot requested a review from Julesssss September 18, 2026 07:39
@marufsharifi

Copy link
Copy Markdown

@Julesssss, Could you please take a look at this when you get a chance. thanks.

@Julesssss
Julesssss merged commit 0ba1d85 into Expensify:main Sep 21, 2026
36 of 38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.91-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Yes — help site changes are required, and I opened a draft PR for them: Docs updates for E/A#99295 document View user history profile action

Why. This PR adds a View user history / View agent history action to profiles and to the Edit agent screen. Nothing under App/docs/articles described it, so there was no documented way for a member to find or understand it.

What the docs PR does.

  • Adds docs/articles/new-expensify/chat/View-User-History.md — one workflow: opening someone's message history from their profile. Covers who can use it, the path on a person's profile and on an agent's profile, what the results are, and an FAQ. It states the access boundary explicitly: results only cover chats you already belong to, and the person is not notified.
  • Updates docs/articles/new-expensify/ai-agents/Create-and-Use-Custom-Agents.md — adds ## How to view an agent's history for the Edit agent path, refreshes the metadata, and notes the capability in the list of what you can do with an agent after creating it.

Copy verified against the running app on web, not read off the diff:

Where Exact label Position
Person's Profile page View user history Between Local time and Notify me about new messages
Agent's Profile page View agent history Between Copilot into account and Notify me about new messages
Edit agent screen View agent history Between the instructions field and Chat with agent
Destination — Chats search, empty input, From: [Name] filter chip plus a Reset link
Two details that changed how I wrote the steps

There is no visible Details button. Clicking the avatar, display name, chevron, or subtitle in the chat header all open the Profile page directly in one click. Details exists only as an accessibility label on that same region, so the article tells members to click the name or avatar instead of naming a button that isn't rendered.

The search box stays empty. The From filter lands as a chip next to the search field rather than as typed text. That reads like a bug on first use, so the article calls it out and there's an FAQ entry for it.

One pre-existing drift I did not fold in. The Agents list row buttons now read Chat with agent, Copilot into account, and Edit, but Create-and-Use-Custom-Agents.md still calls them "Edit, Chat, and Copilot buttons" and tells members to "click the chat icon on the agent's row". Unrelated to this PR, so it's worth a separate fix rather than mixing it in here.

Checks run on the docs branch: npm run spell-changed passed with 0 issues, and ./.github/scripts/createDocsRoutes.sh passed — the new article is picked up automatically, since docs/_data/routes.yml is generated and gitignored. npx prettier --check could not run in this environment because the shared Prettier config failed to load @trivago/prettier-plugin-sort-imports; markdown under docs/ is not a Prettier merge gate, and cspell, which is the gate, passed.

@MelvinBot, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run · view recording

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #101825 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #101826 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #101843 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #101888 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

This PR test 2 failing because of the issue #101888
This issue is reproducible in: All platforms

Bug7266337_1790086302625.ios-repro.mp4

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.91-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Comment thread src/pages/ProfilePage.tsx
{!!accountID && !isAnonymousUserSession() && !!login && (
<MenuItem
shouldShowRightIcon
title={translate(isAgentEmail(login) ? 'profilePage.viewAgentHistory' : 'profilePage.viewUserHistory')}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We replaced the MagnifyingGlass icon to History icon and also changed the title text to more relevant See chat history in #102270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants